Re: [RFC for-next 1/2] IB/{core,uverbs}: ib_uverbs callback registration in ib_core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 07, 2019 at 04:39:29PM +0200, Shamir Rabinovitch wrote:
> From: shamir rabinovitch <shamir.rabinovitch@xxxxxxxxxx>
> 
> next patch will add dependency from ib_umem_get to ib_uverbs.
> this require ib_uverbs callback registartion to prevent circular
> dependecy of the form ib_core -> ib_uverbs -> ib_core that fail
> in depmod check.
> 
> Signed-off-by: shamir rabinovitch <shamir.rabinovitch@xxxxxxxxxx>
> ---
>  drivers/infiniband/core/device.c      | 51 +++++++++++++++++++++++++++
>  drivers/infiniband/core/uverbs_main.c | 11 ++++++
>  include/rdma/ib_verbs.h               | 12 +++++++
>  3 files changed, 74 insertions(+)

Oh this is very ugly..

This is happening because umem is in the wrong module, anything that
touches ucontext is a uverbs component, not a ib_core component.

Looks like it should be fairly trivial to move umem.c to uverbs.ko? 

That should resolve the circular dependency.

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux