> On 4 Jan 2019, at 17:27, Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote: > > On Fri, Jan 04, 2019 at 02:17:20PM +0100, Håkon Bugge wrote: >> When an IB port has been brought back to Active state, after being >> down, ibacm gets an event about it. It will then (re) enumerate the >> devices, and does so by executing an ioctl with SIOCGIFCONF. This >> particular ioctl will only return interfaces that are "running". > > This seems like an ugly hack, should this be using netlink instead of > SIOCGIFCONF to get the interface list? You mean the SIOCGIFCONF ioctl or the commit that is ugly? At least, now we have something that works from kernel clients which requests PRs using GIDs, in an environment with limited pkeys, taking ports down and up, with corresponding move of IP addresses. I am in favour of pursuing this patch. Down the road, the ioctl method can be hardened by using netlink instead, and this patch can be reverted. Thxs, Håkon
