On Fri, Jan 04, 2019 at 08:18:52AM +0100, Christoph Hellwig wrote: > > CH: Does sg_page_iter_dma_address() even make any sense?? > > No, it doesn't and should never have been edited. It's one of these > typical scatterlist abuses in the media code :( Actually I take this back. Due to the sg_page_iter structure iterating over segments first and then pages inside the segment it actually is ok. It just looks very awkward.