On Thu, Jan 03, 2019 at 11:35:43AM +0530, Devesh Sharma wrote:
> > > struct bnxt_re_uctx_resp {
> > > - __u32 dev_id;
> > > - __u32 max_qp;
> > > + __u32 chip_id0;
> > > + __u32 chip_id1;
> >
> > You changed something called max_qp into chip_id1 ? How is that
> > backwards compatible???
> Yes, this is breaking indeed as Leon also commented. replacing with
> union and ABI range check
> will be implemented in V2.
I'm not sure how a union will save you - add the new stuff to the end
is the usual approach.
Jason
