On Fri, Dec 14, 2018 at 08:05:49AM -0800, Yuval Shaia wrote: > Same code is executed in both rxe_param_set_add and rxe_notify functions. > Make one function and call it from both places. > > Note that the code that checks validity of rxe object is omitted since > both callers already make sure it is valid. > > Signed-off-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx> > Reviewed-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx> > Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxx> > --- > drivers/infiniband/sw/rxe/rxe.h | 1 + > drivers/infiniband/sw/rxe/rxe_net.c | 13 +++++++++---- > drivers/infiniband/sw/rxe/rxe_sysfs.c | 12 +----------- > 3 files changed, 11 insertions(+), 15 deletions(-) I rebased and edited this a bit - there is no reason to pass a net and a rxe into the function, rxe->ndev is fine. Applied to for-next Thanks, Jason
