RE: [PATCH rdma-next v1 0/6] Refactor class and device registration code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Leon Romanovsky <leon@xxxxxxxxxx>
> Sent: Thursday, December 20, 2018 2:17 AM
> To: Doug Ledford <dledford@xxxxxxxxxx>
> Cc: Jason Gunthorpe <jgg@xxxxxxxxxxxx>; RDMA mailing list <linux-
> rdma@xxxxxxxxxxxxxxx>; Ira Weiny <ira.weiny@xxxxxxxxx>; Jack Morgenstein
> <jackm@xxxxxxxxxxxx>; Parav Pandit <parav@xxxxxxxxxxxx>
> Subject: Re: [PATCH rdma-next v1 0/6] Refactor class and device registration
> code
> 
> On Wed, Dec 19, 2018 at 04:37:03PM -0500, Doug Ledford wrote:
> > On Wed, 2018-12-19 at 21:14 +0000, Jason Gunthorpe wrote:
> > > On Wed, Dec 19, 2018 at 04:28:00PM +0200, Leon Romanovsky wrote:
> > > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > > >
> > > > Changelog v0->v1:
> > > >  - Address Jason's comment to reuse class name during char device
> creation time
> > > >  - Changed subject from RDMA/umad to IB/umad to be consistent with
> rest patches
> > > >  - Removed extra space after comment in patch-2
> > >
> > > What happened to fixing the refcounting?
> >
> > You're right.  I've dropped the series, it needs a respin.
> 
> Strange, Parav is usually very pedantic to fix all comments.

I am sorry, I missed that Jason's email yday.
I addressed most comments except drvdata() removal due to two devices within one umad_device and changing that wasn't worth enough.
I enqueued to Leon's queue internally, will wait until Jason's response for drvdata().





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux