Re: [EXT] [PATCH 1/1] libqedr: generate WC with IBV_WC_WR_FLUSH_ERR status even WR is unsignaled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 17, 2018 at 09:04:05AM +0000, Michal Kalderon wrote:
> > From: linux-rdma-owner@xxxxxxxxxxxxxxx <linux-rdma-
> > owner@xxxxxxxxxxxxxxx> On Behalf Of Roman Penyaev
> >
> > According to InfiniBand papers:
> >
> >   InfiniBand Architecture Release,
> >   10.7.3.1  Signaled Completions
> >
> >   Note that if a completion error occurs, a Work Completion will
> >   always be generated, even if the signaling indicator requests
> >   an Unsignaled Completion.
> >
> > Signed-off-by: Roman Penyaev <rpenyaev@xxxxxxx>
> > Cc: Ram Amrani <Ram.Amrani@xxxxxxxxxx>
> > Cc: Ariel Elior <Ariel.Elior@xxxxxxxxxx>
> > Cc: linux-rdma@xxxxxxxxxxxxxxx
> > ---
> >  providers/qedr/qelr_verbs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/providers/qedr/qelr_verbs.c b/providers/qedr/qelr_verbs.c index
> > ce172a5e63da..c5edc0978381 100644
> > --- a/providers/qedr/qelr_verbs.c
> > +++ b/providers/qedr/qelr_verbs.c
> > @@ -1911,7 +1911,7 @@ static int qelr_poll_cq_req(struct qelr_qp *qp,
> > struct qelr_cq *cq,
> >                        "Error: POLL CQ with
> > ROCE_CQE_REQ_STS_WORK_REQUEST_FLUSHED_ERR. QP icid=0x%x\n",
> >                        qp->sq.icid);
> >                 cnt = process_req(qp, cq, num_entries, wc, sq_cons,
> > -                                 IBV_WC_WR_FLUSH_ERR, 0);
> > +                                 IBV_WC_WR_FLUSH_ERR, 1);
> >                 break;
> >         default: /* other errors case */
> >                 /* process all WQE before the consumer */
> > --
> > 2.19.1
> Looks good, thanks.
>
> Acked-by: Michal Kalderon <michal.kalderon@xxxxxxxxxxx>

Thanks, merged.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux