Hi Ira, On 12/17/2018 2:15 PM, ira.weiny@xxxxxxxxx wrote: > From: Ira Weiny <ira.weiny@xxxxxxxxx> > > A while ago I wrote these patches for MAD stack tracing. At the time I was > proposing to remove the snoop interface.[1] > > For this submission I'd like to propose adding the tracing and leave the snoop > interface in. While I still don't see a need for the snoop interface, I'm no > longer advocating getting rid of it as the functionality of these patches is > different. I have a few questions on this patch series: Should the agent, umad, and SMP trace points also be checked for being enabled as the send and receive ones are ? What is the overhead of the trace enabled check when the trace points are off ? Are there MAD performance numbers with tracing off before and after these patches ? Does this work with RMPP ? Was this tested with RMPP responses such as SA GetTableResp ? Should GSI MAD trace points include the GRH if it's present ? Thanks. -- Hal > In addition I wrote a sample eBPF which shows how one can further filter at the > tracepoints to distill the information being traced. I don't know if this > should be submitted through another tree or if it is ok to take though > linux-rdma? > > Ira > > [1] https://www.spinics.net/lists/linux-rdma/msg29109.html > > > Ira Weiny (6): > IB/MAD: Add send path trace points > IB/MAD: Add recv path trace point > IB/MAD: Add agent trace points > IB/UMAD: Add umad trace points > IB/MAD: Add SMP details to MAD tracing > BPF: Add sample code for new ib_umad tracepoint > > drivers/infiniband/core/mad.c | 95 ++++++++- > drivers/infiniband/core/user_mad.c | 7 + > include/trace/events/ib_mad.h | 391 +++++++++++++++++++++++++++++++++++++ > include/trace/events/ib_umad.h | 140 +++++++++++++ > samples/bpf/Makefile | 3 + > samples/bpf/ibumad_kern.c | 123 ++++++++++++ > samples/bpf/ibumad_user.c | 120 ++++++++++++ > 7 files changed, 878 insertions(+), 1 deletion(-) > create mode 100644 include/trace/events/ib_mad.h > create mode 100644 include/trace/events/ib_umad.h > create mode 100644 samples/bpf/ibumad_kern.c > create mode 100644 samples/bpf/ibumad_user.c >
