Re: [PATCH rdma-next v1 1/6] IB/umad: Use class name while creating char device regions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 19, 2018 at 04:28:01PM +0200, Leon Romanovsky wrote:
> From: Parav Pandit <parav@xxxxxxxxxxxx>
> 
> Use class name 'infiniband_mad' while creating char device regions.
> While we are changing the creation sequence of class and char device
> regions, follow equivalent destroy sequence.
> 
> Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx>
> Reviewed-by: Jack Morgenstein <jackm@xxxxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
>  drivers/infiniband/core/user_mad.c | 52 ++++++++++++++----------------
>  1 file changed, 24 insertions(+), 28 deletions(-)

This patch would be much smaller if it was ordered after patch 3, I
think I said this in the original comments. patch 3 makes the class a
static global and so umad_class.name is always valid and the
re-organizing isn't required.

Jason




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux