Hi Mark, > -----Original Message----- > From: Leon Romanovsky <leon@xxxxxxxxxx> > Sent: Wednesday, December 12, 2018 1:10 AM > To: Mark Bloch <markb@xxxxxxxxxxxx> > Cc: Jarod Wilson <jarod@xxxxxxxxxx>; Parav Pandit > <parav@xxxxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; Doug Ledford > <dledford@xxxxxxxxxx>; Honggang Li <honli@xxxxxxxxxx> > Subject: Re: [PATCH rdma-core] Add Red Hat's ibdev2netdev helper > > On Wed, Dec 12, 2018 at 06:38:39AM +0000, Mark Bloch wrote: > > > > > > On 12/11/2018 21:27, Leon Romanovsky wrote: > > > On Tue, Dec 11, 2018 at 04:53:49PM -0500, Jarod Wilson wrote: > > >> On 2018-12-11 4:17 PM, Parav Pandit wrote: > > >>> > > >>> > > >>>> -----Original Message----- > > >>>> From: linux-rdma-owner@xxxxxxxxxxxxxxx <linux-rdma- > > >>>> owner@xxxxxxxxxxxxxxx> On Behalf Of Mark Bloch > > >>>> Sent: Tuesday, December 11, 2018 1:57 PM > > >>>> To: Jarod Wilson <jarod@xxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx > > >>>> Cc: Doug Ledford <dledford@xxxxxxxxxx>; Honggang Li > > >>>> <honli@xxxxxxxxxx> > > >>>> Subject: Re: [PATCH rdma-core] Add Red Hat's ibdev2netdev helper > > >>>> > > >>>> > > >>>> > > >>>> On 12/11/18 11:46 AM, Jarod Wilson wrote: > > >>>>> This is a helper script that Red Hat had previously been > > >>>>> including in it's ibutils package, which is no more, with the > > >>>>> retirement of ibutils and > > >>>>> ibutils2 being proprietary to Mellanox now. This script still > > >>>>> has use, and needs a better home, so we'd like to add it to > > >>>>> rdma-core's redhat/ directory -- if not somewhere more generic, > > >>>>> should other distros wish to make use of it as well. > > >>>> > > >>>> Why not tell users to use rdma tool (iproute2)? > > >>>> > > >>> Because rdma tool currently doesn’t show corresponding IPoIB upper > netdevice(s) of for the IB device. > > >>> For a given rdma device there can be multiple netdevices exist for > RoCE ports. > > >>> Rdma tool (and ibdev2netdev) doesn't show them. > > >>> The scope of ibdev2netdev currently is wider than what rdma tool > shows. > > >>> So yes, its good recommendation to RoCE and representor users. > > >> > > >> We've actually had some folks notice it was missing from RHEL-8.0 > > >> beta, and explicitly request it, because they have various > > >> infrastructure that was expecting it to be there. It's just a shell > > >> script, and could be updated along the way to use the rdma tool > > >> from iproute2, or become completely obsolete at some point. But > > >> we're definitely some demand to keep it around for the moment. > > > > > > It is already obsolete and rdmatool replaces it. I see no value in > > > keeping abandoned tool in upstream repository. > > > > > > Regarding Parav's point, lack of IPoIB translations, iroute2 is an > > > open-source project and people are encouraged to extend it. If I > > > judge by number of customer requests to me (zero) to implement it, > > > there is no demand in such functionality. > > > > Well, a quick prototype follows below, the question is should I work > > on it or not, does anyone core? > > Parav and I are care, I have no clue about the rest of the world. > > It will be better to start from mockup of rdmatool output. > > Thanks Your work is certainly useful. This allows users to start using rdma tool regardless of underlying link layer to get ib device to net device(s) mapping.
