On Thu, 2018-12-13 at 03:37 +0000, Jason Gunthorpe wrote: > On Wed, Dec 12, 2018 at 07:11:37PM -0800, Saeed Mahameed wrote: > > From: Mark Bloch <markb@xxxxxxxxxxxx> > > > > When in switchdev mode and the add function is called by the core > > level driver, make sure we only register the callbacks, but don't > > create the mlx5 IB device or initialize anything. With this change > > all the IB devices in switchdev mode are created only once the load > > callback is invoked by the e-switch core sub-module. This follows > > the design paradigm under which the all the Eth representors must > > be loaded before any of IB reprs is loaded. > > > > Signed-off-by: Mark Bloch <markb@xxxxxxxxxxxx> > > Acked-by: Or Gerlitz <ogerlitz@xxxxxxxxxxxx> > > Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > Signed-off-by: Saeed Mahameed <saeedm@xxxxxxxxxxxx> > > --- > > drivers/infiniband/hw/mlx5/ib_rep.c | 11 ++++++++++- > > drivers/infiniband/hw/mlx5/main.c | 29 +++++++++--------------- > > ---- > > drivers/infiniband/hw/mlx5/mlx5_ib.h | 1 - > > 3 files changed, 19 insertions(+), 22 deletions(-) > > Why is this going in the shared branch? This looks like an IB patch?? > Some upcoming changes to support uplink representor will demand this refactoring in the mlx5 IB driver, otherwise we will have a broken rdma eswitch representors untill the two trees are merged. > Jason