On Wed, 2018-12-12 at 17:10 +0200, Leon Romanovsky wrote: > On Wed, Dec 12, 2018 at 08:33:53AM +0000, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function > > 'mlx5e_vport_rep_load': > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1490:21: warning: > > variable 'upriv' set but not used [-Wunused-but-set-variable] > > > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function > > 'mlx5e_vport_rep_unload': > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1557:21: warning: > > variable 'upriv' set but not used [-Wunused-but-set-variable] > > > > It not used any more since commit ef381359e3a8 ("net/mlx5e: Replace > > egdev with > > indirect block notifications"). Also remove unused variable > > 'uplink_rpriv' > > after this change. > > > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > > --- > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 10 ---------- > > 1 file changed, 10 deletions(-) > > > > Thanks, > Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> Acked-by: Saeed Mahameed <saeedm@xxxxxxxxxxxx> Dave as agreed, you can apply this patch to net-next directly. Thanks, Saeed.