On 12/12/18 1:01 AM, Jason Gunthorpe wrote: > On Mon, Dec 10, 2018 at 09:09:28PM +0200, Kamal Heib wrote: >> This patchset introduce a new structure that will contain all the >> infiniband device operations, the structure will be used by the >> providers to initialize their supported operations. This patchset also >> includes the required changes in the core and ulps to start using it. >> >> Changes from v4: >> * Include the missing fist patch. >> * Include patch [1] that this patch set depend on and it should be >> dropped when merging for-rc with for-next. >> >> [1] RDMA/rdmavt: Fix rvt_create_ah function signature > > So, I almost didn't apply this, particularly since I don't see how it > could have even worked with that ops bug, and it didn't apply > cleanly.. But I fixed all the merge issues and fixed the bug, and the > pointless checkpatch violations. So applied to for-next > > You should probably check carefully. Maybe run some tests... > > Jason > Hi Jason, We have two issues that got fixed: 1- when CONFIG_MLX5_CORE_IPOIB isn't set: I already sent a fixup off the list that should fix it, but I also saw that Leaon sent it too. 2- Reading the ibdev_fn. So, I tested "rdma/wip/jgg-for-next" with the above two fixes on top of it and it looks good to me. Thanks, Kamal