On Tue, Dec 11, 2018 at 09:10:46AM -0700, Jason Gunthorpe wrote: > On Tue, Dec 11, 2018 at 11:37:30AM +0200, Yuval Shaia wrote: > > > > Will it be easier to remove all declarations from ib_device and add new > > > > member struct ib_device_ops *ops to ib_device this way objective will be > > > > achieved (code more readable) while still preserving single place of > > > > declaration? > > > > > > Please take a look on the last patch in this patch set, it removes the functions > > > within the ib_device and add the ib_device_ops as a member to the ib_device, > > > this was done to make it easier to review this huge patch set. > > > > Ok, saw it, so wondering why two separate patches where second undo stuff > > made by first. > > This arrangment has lower LOC changes > > > Anyways, is it possible somehow to include the setting of uverbs_cmd_mask? > > I want to delete this thing, I think we can now, just needs some > driver auditing (maybe Kamal will do this next :)) > Maybe :-) > Jason
