On 11-Dec-18 18:12, Jason Gunthorpe wrote: > On Tue, Dec 11, 2018 at 10:59:24AM +0200, Gal Pressman wrote: >> Hi Jason and Doug, >> This patchset adds a 'sleepable' flag to create/destroy address handle flows in >> order to allow drivers to wait for device completion instead of busy polling >> when possible. >> >> Patches #1, #2 add the flag to create/destroy AH callbacks and change all the >> drivers, patches #3, #4 change bnxt_re driver to make use of the flag and not >> poll for firmware completion. >> >> I had some issues with rdmavt callbacks, it looks like their create_ah function >> is not matching the callback signature. Not entirely sure if that's intended or >> not so I didn't change it, let me know what you think about that. > > Kamal discovered this too, it is fixed in -rc, send your patches > against a branch with -rc merged in to for-next... > > Jason > Thanks, will send as v2 soon.