Re: [PATCH rdma-next] RDMA/ocrdma: Use PCI-ID as an identification in debugfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 11, 2018 at 12:04:42PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> 
> In opposite to current implementation of identification
> based on device name, PCI-ID identification provides stable
> names suitable for device rename. Change ocrdma debugfs
> representation to use PCI-ID.
> 
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
>  drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> index 290d776edf48..dd15474b19b7 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> @@ -760,12 +760,13 @@ static const struct file_operations ocrdma_dbg_ops = {
> 
>  void ocrdma_add_port_stats(struct ocrdma_dev *dev)
>  {
> +	const struct pci_dev *pdev = dev->nic_info.pdev;
> +
>  	if (!ocrdma_dbgfs_dir)
>  		return;
> 
>  	/* Create post stats base dir */
> -	dev->dir =
> -		debugfs_create_dir(dev_name(&dev->ibdev.dev), ocrdma_dbgfs_dir);
> +	dev->dir = debugfs_create_dir(pci_name(pdev), ocrdma_dbgfs_dir);
>  	if (!dev->dir)
>  		goto err;

Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>

> 
> --
> 2.19.1
> 



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux