> > + if (!ib_dev->advise_mr) > > + return -EOPNOTSUPP; > > Now that my series was merged this stuff should be done via the > UAPI_DEF_OBJ_NEEDS_FN stuff.. Except it only works on a fine grained > level for write() commands. Sigh. > > Let's just add a FIXME comment here. > OK > > +enum ib_uverbs_advise_mr_flag { > > + IB_UVERBS_ADVISE_MR_FLAG_FLUSH = (1 << 0), > > Brackets are redundant.. > OK > I can make these changes, but since it was only posted 2 days ago and > is a new common uapi it has to wait.. > > Jason