On Mon, Dec 10, 2018 at 4:49 PM Cong Wang <xiyou.wangcong@xxxxxxxxx> wrote:
>
> On Mon, Dec 10, 2018 at 1:55 PM Saeed Mahameed <saeedm@xxxxxxxxxxxx> wrote:
> > +enum mlx5_monitor_counter_ppcnt {
> > + MLX5_QUERY_MONITOR_PPCNT_IN_RANGE_LENGTH_ERRORS = 0X0,
> > + MLX5_QUERY_MONITOR_PPCNT_OUT_OF_RANGE_LENGTH_FIELD = 0X1,
> > + MLX5_QUERY_MONITOR_PPCNT_FRAME_TOO_LONG_ERRORS = 0X2,
> > + MLX5_QUERY_MONITOR_PPCNT_FRAME_CHECK_SEQUENCE_ERRORS = 0X3,
> > + MLX5_QUERY_MONITOR_PPCNT_ALIGNMENT_ERRORS = 0X4,
> > + MLX5_QUERY_MONITOR_PPCNT_IF_OUT_DISCARDS = 0X5,
> > +};
> > +
> > +enum {
> > + MLX5_QUERY_MONITOR_Q_COUNTER_RX_OUT_OF_BUFFER = 0X4,
> > +};
>
> Is there any reason to capitalize these 0X prefixes?
>
Nice catch, apparently gcc is case insensitive for hex values,
everything works and all static checkers are happy.
this requires eagle eyes to catch, will fix this up.
Thanks Cong.
> Thanks.
