RE: [PATCH rdma-core] verbs: Provide native ioctl implementations for trivial destroy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: linux-rdma-owner@xxxxxxxxxxxxxxx <linux-rdma-
> owner@xxxxxxxxxxxxxxx> On Behalf Of Leon Romanovsky
> Sent: Monday, December 10, 2018 12:30 AM
> To: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> Cc: linux-rdma@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH rdma-core] verbs: Provide native ioctl implementations
> for trivial destroy
> 
> On Sun, Dec 09, 2018 at 08:39:39PM +0000, Jason Gunthorpe wrote:
> > In the kernel these all go through the common destroy flow and take no
> > code. Call out to ioctl directly for these destroys instead of using
> > write.
> >
> > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> > ---
> >  libibverbs/CMakeLists.txt |   7 +++
> >  libibverbs/cmd.c          | 117 --------------------------------------
> >  libibverbs/cmd_ah.c       |  63 ++++++++++++++++++++
> >  libibverbs/cmd_flow.c     |  65 +++++++++++++++++++++
> >  libibverbs/cmd_mr.c       |  65 +++++++++++++++++++++
> >  libibverbs/cmd_mw.c       |  64 +++++++++++++++++++++
> >  libibverbs/cmd_pd.c       |  64 +++++++++++++++++++++
> >  libibverbs/cmd_rwq_ind.c  |  66 +++++++++++++++++++++
> >  libibverbs/cmd_xrcd.c     |  64 +++++++++++++++++++++
> >  9 files changed, 458 insertions(+), 117 deletions(-)  create mode
> > 100644 libibverbs/cmd_ah.c  create mode 100644 libibverbs/cmd_flow.c
> > create mode 100644 libibverbs/cmd_mr.c  create mode 100644
> > libibverbs/cmd_mw.c  create mode 100644 libibverbs/cmd_pd.c  create
> > mode 100644 libibverbs/cmd_rwq_ind.c  create mode 100644
> > libibverbs/cmd_xrcd.c
> >
> > This is the matching userspace patch for
> >
> > https://patchwork.kernel.org/patch/10706139/
> >
> > It is still being testing so for review only.
> 
> FYI, it is not part of our regression testing.
> 

With updated kernel headers I tested manually this using rtool where rdma_core was compiled twice once using IOCTL_MODE=ioctl and other time using IOCTL_MODE=write

https://github.com/paravmellanox/rtool.git

rdma_resource_lat -d mlx5_3 -c 4 -R { pd, mr, uctx, mw, cq, qp, xrcd, wq, rqit, ah, flow}





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux