Re: [PATCH rdma-rc] RDMA/vmw_pvrdma: Use atomic memory allocation in create AH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 10, 2018 at 05:17:25PM +0200, Gal Pressman wrote:
> Create address handle callback should not sleep, use GFP_ATOMIC instead
> of GFP_KERNEL for memory allocation.
> 
> Fixes: 29c8d9eba550 ("IB: Add vmw_pvrdma driver")
> Cc: Adit Ranadive <aditr@xxxxxxxxxx>
> Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx>
> ---
>  drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
> index b65d10b0a875..f4cb5cf26006 100644
> --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
> +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
> @@ -555,7 +555,7 @@ struct ib_ah *pvrdma_create_ah(struct ib_pd *pd, struct rdma_ah_attr *ah_attr,
>  	if (!atomic_add_unless(&dev->num_ahs, 1, dev->dsr->caps.max_ah))
>  		return ERR_PTR(-ENOMEM);
>  
> -	ah = kzalloc(sizeof(*ah), GFP_KERNEL);
> +	ah = kzalloc(sizeof(*ah), GFP_ATOMIC);
>  	if (!ah) {
>  		atomic_dec(&dev->num_ahs);
>  		return ERR_PTR(-ENOMEM);

Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>

> -- 
> 2.7.4
> 



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux