On Mon, Dec 10, 2018 at 8:12 AM Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote: > > On Sun, Dec 09, 2018 at 07:04:39PM -0800, Saeed Mahameed wrote: > > From: Eli Britstein <elibr@xxxxxxxxxxxx> > > > > Change the driver flow destination struct to use bit flags with the vhca > > id valid being the 1st one. Done to avoid bool fields in structs, as > > warned by static checkers, with no functionality change. > > This is a thing now? I thought the warning was not to use bool with > bitfields for some reason? > Yea, the commit message is kinda silly, But the patch makes sense since having a flag can be more extendable in the future, e.g in the next patch: MLX5_FLOW_DEST_VPORT_REFORMAT_ID We can fix the commit message. > Jason
