On 12/9/2018 4:53 AM, Yuval Shaia wrote: > On Thu, Dec 06, 2018 at 10:13:30AM -0600, Steve Wise wrote: >> On 12/6/2018 5:01 AM, Yuval Shaia wrote: >>> Same code is executed in both rxe_param_set_add and rxe_notify >>> functions. >>> Make one function and call it from both places. >>> >>> Note that the code that checks validity of rxe object is omitted since >>> both callers already make sure it is valid. >>> >>> Signed-off-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx> >> Reviewed-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx> >> >> I need this patch as part of my newlink/dellink submission [1]. It >> fixes a bug in my reference logic by the fact that it removes the call >> to net_to_rxe(). May I include it in my patch series? That way we >> don't create a dependency until both merge. >> >> [1] https://www.spinics.net/lists/linux-rdma/msg71873.html >> >> Thanks, >> >> Steve > Please add Bart's r-b Sure.
