Re: [PATCH rdma-next] RDMA/mlx5: Delete unreachable handle_atomic code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 09, 2018 at 12:44:40PM +0200, Leon Romanovsky wrote:
> -static void handle_atomics(struct mlx5_ib_qp *qp, struct mlx5_cqe64 *cqe64,
> -			   u16 tail, u16 head)
> -{
> -	u16 idx;
> -
> -	do {
> -		idx = tail & (qp->sq.wqe_cnt - 1);
> -		handle_atomic(qp, cqe64, idx);
> -		if (idx == head)
> -			break;
> -
> -		tail = qp->sq.w_list[idx].next;
> -	} while (1);
> -	tail = qp->sq.w_list[idx].next;
> -	qp->sq.last_poll = tail;

This line is the only thing that has an external impact, is it OK to
delete it?

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux