On Thu, 2018-12-06 at 21:03 +-0800, Yanjun Zhu wrote: +AD4 On 2018/12/6 19:01, Yuval Shaia wrote: +AD4 +AD4 +-void rxe+AF8-set+AF8-port+AF8-state(struct net+AF8-device +ACo-ndev, struct rxe+AF8-dev +ACo-rxe) +AD4 +AD4 an inline function is better? What makes you think that declaring this function 'inline' would be better? The compiler should be smart enough to figure out that this function can be inlined without declaring it 'inline'. Bart.