Re: [PATCH] IB/rxe: Warn when objects are invalid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-12-06 at 13:09 +-0200, Yuval Shaia wrote:
+AD4 Since callers never validates return value let's make sure objects are
+AD4 valid here and do not return NULL.

This is not sufficient as motivation to make this change. A better motivation
would e.g. be that you have audited all callers and verified that none of the
callers passes a NULL pointer. Another possible motivation could be that you
have tested these code paths extensively and that none of the removed warning
statements has been triggered.

Bart.



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux