On Thu, Dec 06, 2018 at 04:31:40PM +0000, Hefty, Sean wrote: > > > efa_port_link_layer() need to return more appropriate link layer > > that reflects the addresses defined in ah. > > > > > > > We can add a new EFA link layer if it makes sense, the address format > > is proprietary (does not match existing link types). > > If the link layer is truly Ethernet, I don’t think it makes sense to > return anything else. The link layer should not define the network > addressing used in the AH. Introducing a new address format field > for this purpose makes more sense. Yah, we have the crazy if (rdma_cap*) bleck stuff for figuring out what the AH is in the kernel. But none of this really matters for a non-verbs driver. Jason
