On Thu, Dec 06, 2018 at 01:06:15PM +0200, Yuval Shaia wrote:
> RXE has only one port. No need to hard code it on every verb instead use
> rdma_is_port_valid to validate the given port number.
>
> Signed-off-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
> ---
> drivers/infiniband/sw/rxe/rxe_verbs.c | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
> index 30817c79ba96..88fdb8890038 100644
> --- a/drivers/infiniband/sw/rxe/rxe_verbs.c
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
> @@ -51,6 +51,16 @@ static int rxe_query_device(struct ib_device *dev,
> return 0;
> }
>
> +static bool rxe_is_port_valid(struct rxe_dev *rxe, u8 port_num)
> +{
> + if (unlikely(!rdma_is_port_valid(&rxe->ib_dev, port_num))) {
> + pr_warn("Invalid port number %d\n", port_num);
> + return 0;
> + }
> +
> + return 1;
> +}
Let's use directly rdma_is_port_valid() without extra layer.
Thanks
Attachment:
signature.asc
Description: PGP signature
