On Tue, 2018-12-04 at 20:55 -0800, Cong Wang wrote: > On Tue, Dec 4, 2018 at 6:06 PM Saeed Mahameed <saeedm@xxxxxxxxxxxx> > wrote: > > +static inline u8 get_cqe_opcode(struct mlx5_cqe64 *cqe) > > Make it const please. Please be specific I can do: static inline u8 get_cqe_opcode(struct mlx5_cqe64 const *cqe) if that what you mean. But i will leave it for a later time to do it for all cqe fields getter functions in this file, i will keep the code uniform for now.