On Sat, Dec 01, 2018 at 04:29:25PM +0200, Leon Romanovsky wrote: > On Fri, Nov 30, 2018 at 04:28:51PM +0000, Jason Gunthorpe wrote: > > On Thu, Nov 29, 2018 at 07:31:49AM +0200, Leon Romanovsky wrote: > > > On Wed, Nov 28, 2018 at 09:22:13PM +0000, Jason Gunthorpe wrote: > > > > On Wed, Nov 28, 2018 at 03:57:08PM +0200, Leon Romanovsky wrote: > > > > > diff --git a/buildlib/travis-build b/buildlib/travis-build > > > > > index c241eb06..c8c3e539 100755 > > > > > +++ b/buildlib/travis-build > > > > > @@ -9,7 +9,7 @@ mkdir build-travis build32 build-sparse build-aarch64 > > > > > > > > > > # Build with latest clang first > > > > > cd build-travis > > > > > -CC=clang-7 CFLAGS=-Werror cmake -GNinja .. -DIOCTL_MODE=both -DENABLE_STATIC=1 > > > > > +CC=clang-7 CFLAGS=-Werror cmake -GNinja .. -DIOCTL_MODE=both -DENABLE_STATIC=1 -DNO_PYVERBS=1 > > > > > ninja > > > > > ../buildlib/check-build --src .. --cc clang-7 > > > > > > > > Now that we have a Senial base image we shouldn't need NO_PYVERBS anymore? > > > > > > Last time, when I wrote this patch, cython produced C files, which were > > > not good enough for "CC=clang-7", this is why I disabled back then. > > > > > > I'll recheck, maybe my changes in compilation flags fixed those > > > failures. > > > > It would be problematic if we get any warnings from the pyverbs stuff. > > > > I had expected that cmake would add the necessary flags to the cython > > compile to turn off the things it has trouble with > > Finally, I found the reason why it failed in Ubuntu: > find_package(PythonInterp) > find_package(cython) <----- cleared various PYTHON_* variables. > find_package(PythonLibs) Really? That is the wrong way to write a find_package helper, the cython one must be messed up :( Jason
