On Thu, Nov 29, 2018 at 06:30:13AM +0000, Jason Gunthorpe wrote:
> On Thu, Nov 29, 2018 at 07:34:54AM +0200, Leon Romanovsky wrote:
> > On Wed, Nov 28, 2018 at 09:20:39PM +0000, Jason Gunthorpe wrote:
> > > On Wed, Nov 28, 2018 at 03:56:59PM +0200, Leon Romanovsky wrote:
> > > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > > >
> > > > Run over all major distributions to ensure that rdma-core
> > > > is packaged properly. As part of this change, we are moving
> > > > debian check from manual run to be part of packaging and
> > > > check release mode only.
> > > >
> > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > > > buildlib/package-build-test | 11 +++++++++--
> > > > buildlib/travis-build | 14 --------------
> > > > 2 files changed, 9 insertions(+), 16 deletions(-)
> > > >
> > > > diff --git a/buildlib/package-build-test b/buildlib/package-build-test
> > > > index 46a1cf6f..1ae80b4c 100755
> > > > +++ b/buildlib/package-build-test
> > > > @@ -11,11 +11,18 @@ if [ -e "/.dockerenv" ] || (grep -q docker /proc/self/cgroup &>/dev/null); then
> > > > exit 0
> > > > fi
> > > >
> > > > -for OS in centos7 tumbleweed
> > > > +for OS in centos7 tumbleweed fedora ubuntu debian-experimental
> > >
> > > I don't think we should do this, this makes the build take a lot
> > > longer.. And it causes travis to truncate the log output in the main
> > > view..
> > >
> > > If we are going to do this we should be running the per-OS builds in
> > > parallel since they don't share anything
> > >
> > > And there are warnings in these builds which are not detected
> > >
> > > > diff --git a/buildlib/travis-build b/buildlib/travis-build
> > > > index 7e0f2fba..c241eb06 100755
> > > > +++ b/buildlib/travis-build
> > > > @@ -45,17 +45,3 @@ rm CMakeCache.txt
> > > > CC=clang-7 CFLAGS=-Werror cmake -GNinja .. -DIOCTL_MODE=both
> > > > ninja
> > > > cp ../util/udma_barrier.h.old ../util/udma_barrier.h
> > > > -
> > > > -# Finally run through gcc-7 64 bit through the debian packaging This gives a
> > > > -# good clue if patches are changing packaging related things, the RPM stuff
> > > > -# will have to be audited by hand.
> > > > -
> > > > -# When running cmake through debian/rules it is hard to set -Werror,
> > > > -# instead force it on by changing the CMakeLists.txt
> > > > -cd ..
> > > > -echo 'set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror")' >> buildlib/RDMA_EnableCStd.cmake
> > > > -sed -i -e 's/-DCMAKE_BUILD_TYPE=Release//g' debian/rules
> > > > -sed -i -e 's/ninja \(.*\)-v/ninja \1/g' debian/rules
> > >
> > > This drops the Xenial gcc-7 64 bit -Werror build, which I don't want
> > > to do..
> >
> > I'll check that I can do, my preference is to move to something more
> > bleeding edge gcc than gcc-7.
>
> We can do that now that we have Xenial, the blocker was that the ppa
> didn't build for trusty anymore. Just update to gcc-8 in the apt
> section in the travis.yml and it should be good.
I sent standalone patch for that.
https://patchwork.kernel.org/patch/10707547/
https://github.com/linux-rdma/rdma-core/pull/435
Thanks
>
> Jason
Attachment:
signature.asc
Description: PGP signature
