On Fri, Nov 23, 2018 at 11:19:30AM -0700, Jason Gunthorpe wrote: > On Fri, Nov 23, 2018 at 07:44:02PM +0200, Leon Romanovsky wrote: > > On Fri, Nov 23, 2018 at 07:28:58PM +0200, Jason Gunthorpe wrote: > > > On Fri, Nov 23, 2018 at 07:21:26PM +0200, Leon Romanovsky wrote: > > > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > > > > > > > Default travis image is trusty which is Ubuntu 14.04, four years > > > > after this version is released, we will try to move to latest and > > > > shiny travis image - xenial, Ubuntu 16.04. > > > > > > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > > > PR to see my struggles :) > > > > https://github.com/linux-rdma/rdma-core/pull/433 > > > > .travis.yml | 3 +-- > > > > buildlib/cbuild | 8 ++++---- > > > > buildlib/travis-build | 6 +++--- > > > > 3 files changed, 8 insertions(+), 9 deletions(-) > > > > > > > > diff --git a/.travis.yml b/.travis.yml > > > > index 9794c1c7..c4ce0581 100644 > > > > +++ b/.travis.yml > > > > @@ -1,7 +1,6 @@ > > > > language: c > > > > # We don't support any distro earlier than trusty > > > ^^^^^^ > > > > > > Missed a spot > > > > > > Also this needs to change/go away: > > > > I left it intentionally, because we still can create DEB packages with > > cbuild on trusty and I was under impression that this comment is related > > to that and not to travis base. > > The comment is related to what the travis.yml needs, and if we run the > pyverbs build then it needs xenial. No problem, I'll update > > When we build trusty packages it should not build pyverbs in cbuild Definitely > > > > > @@ -280,12 +280,12 @@ class travis(APTEnvironment): > > > > def get_clang(self): > > > > """We are using the clang that comes in travis, which is not part of our base > > > > docker container, install something similar by hand.""" > > > > - llvm_tar = "clang+llvm-5.0.2-x86_64-linux-gnu-ubuntu-14.04.tar.xz" > > > > + llvm_tar = "clang+llvm-7.0.0-x86_64-linux-gnu-ubuntu-16.04.tar.xz" > > > > cmds = [ > > > > - """RUN wget -q http://releases.llvm.org/5.0.2/{0} -O /tmp/{0} && \\ > > > > + """RUN wget -q http://releases.llvm.org/7.0.0/{0} -O /tmp/{0} && \\ > > > > tar xf /tmp/{0} -C /usr/local/ && \\ > > > > rm /tmp/{0} && \\ > > > > - (cd /usr/local/bin/ && ln -sf ../clang*/bin/clang-5.0 .)""".format(llvm_tar)]; > > > > + (cd /usr/local/bin/ && ln -sf ../clang*/bin/clang-7 .)""".format(llvm_tar)]; > > > > return cmds; > > > > > > I wonder if we can go back to using the apt.llvm.org version of > > > clang. We only stopped because it became broken.. > > > > I don't see any advantages of using APT. This specific hack worked and > > works now too. > > Less likely to have random breakage if the tar binaries get new shlib > dependencies.. It is general answer, in our case, we stick with specific version as long as travis won't update its base image. Thanks > > Jason
Attachment:
signature.asc
Description: PGP signature
