On Mon, Nov 19, 2018 at 4:20 AM Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > On Mon, Nov 19, 2018 at 06:56:56PM +0800, Tao Tian wrote: > > This patch realizes the resoures track for hip08. It allows > > dumping important cq context state which is useful for > > debugging. we will support more resource track later. > > > > the output should be as follows. > > $ ./rdma res show cq dev hnseth0 -d > > dev hnseth0 cqe 1024 users 2 poll-ctx WORKQUEUE pid 0 comm [ib_core] cq_st 0x2a8 > > 1 cqn 0x0 cur_cqe 0xf7b97 cqe_hop_num 0x40000000 nxt_cqe 0xf7b96 cqe_sz 0x0 cq_p > > roducer 0x0 cq_consumer 0x0 cqe_ba 0x1ef71e00 nxt_ba 0x0 db_record_en 0xf7b98001 > > db_record 0x0 cqe_cnt 0x0 cqe_period 0x0 cqe_timer 0x38cf9bf se_cqe 0x0 > > Except the fact that it looks pretty awful and you didn't really think > about your users who will see it, some parameters are useful for everyone > and some parameters look like addresses. The implementation looks good to me. I agree, I don't think it is a good idea to unconditionally call rdma_nl_put_driver_u32_hex. The intention of the format specifier was to have the kernel indicate an appropriate formatting based on actual the data. Only things that make sense in hex should be printed that way (addresses, bit flags, etc). Other values should be displayed in decimal. Jason
