Re: [PATCH rdma-rc] RDMA/mlx5: Fix fence type for IB_WR_LOCAL_INV WR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 08, 2018 at 09:13:27AM +0200, Leon Romanovsky wrote:
> On Wed, Nov 07, 2018 at 03:42:57PM -0700, Jason Gunthorpe wrote:
> > On Mon, Nov 05, 2018 at 08:07:37AM +0200, Leon Romanovsky wrote:
> > > From: Majd Dibbiny <majd@xxxxxxxxxxxx>
> > >
> > > Currently, for IB_WR_LOCAL_INV WR, when the next fence is None,
> > > the current fence will be SMALL instead of Normal Fence.
> > >
> > > Fixed the logic to set the correct fence type.
> > >
> > > Fixes: 6e8484c5cf07 ("RDMA/mlx5: set UMR wqe fence according to HCA cap")
> > > Signed-off-by: Majd Dibbiny <majd@xxxxxxxxxxxx>
> > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > > ---
> > >  drivers/infiniband/hw/mlx5/qp.c | 19 ++++++++++---------
> > >  1 file changed, 10 insertions(+), 9 deletions(-)
> >
> > This needs a better commit message for -rc
> >
> > What is the user impact of this bug?
>
>
> Without this patch krping doesn't work on CX-5 devices and throws following error:
>
> The error messages are from CX5 driver are: (from server side)
> [ 710.434014] mlx5_0:dump_cqe:278:(pid 2712): dump error cqe
> [ 710.434016] 00000000 00000000 00000000 00000000
> [ 710.434016] 00000000 00000000 00000000 00000000
> [ 710.434017] 00000000 00000000 00000000 00000000
> [ 710.434018] 00000000 93003204 100000b8 000524d2
> [ 710.434019] krping: cq completion failed with wr_id 0 status 4 opcode
> 128 vender_err 32
>
> Krping commands:
> server:
> echo "server,addr=100.10.10.8,validate,verbose,port=9999" > /proc/krping
>
> client:
> echo "client,addr=100.10.10.8,port=9999,validate,verbose,count=4" >
> /proc/krping

Jason,

Do you expect from me anything in regards to this patch?

Thanks

>
> Thanks
>
> >
> > Jason


Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux