On Fri, Nov 16, 2018 at 08:10:35PM +0000, Ruhl, Michael J wrote: > >-----Original Message----- > >From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma- > >owner@xxxxxxxxxxxxxxx] On Behalf Of Leon Romanovsky > >Sent: Sunday, November 4, 2018 2:11 PM > >To: David Ahern <dsahern@xxxxxxxxx> > >Cc: Leon Romanovsky <leonro@xxxxxxxxxxxx>; netdev > ><netdev@xxxxxxxxxxxxxxx>; RDMA mailing list <linux-rdma@xxxxxxxxxxxxxxx>; > >Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx> > >Subject: [PATCH iproute2-next v3] rdma: Document IB device renaming > >option > > > >From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > Hi Leon, > > After looking at this and Steve Wise's changes for the ADDLINK/DELLINK, > it occurred to me that the driver that handed the name to ib_register_device() > might be interested in knowing that this name change occurred. > > Are there plans to include a some kind of notify mechanism so drivers can > find out when things like this occur? At least for device rename, I don't see any real need for such event, because drivers are not supposed to rely on names. I would say that it is probably driver bug to rely on device name during its execution. > > Is this something that should be done? I think yes, we can extend ib_event to support more events than now, but should we? > > Thanks, > > Mike > > >[leonro@server /]$ lspci |grep -i Ether > >00:08.0 Ethernet controller: Red Hat, Inc. Virtio network device > >00:09.0 Ethernet controller: Mellanox Technologies MT27700 Family > >[ConnectX-4] > >[leonro@server /]$ sudo rdma dev > >1: mlx5_0: node_type ca fw 3.8.9999 node_guid 5254:00c0:fe12:3455 > >sys_image_guid 5254:00c0:fe12:3455 > >[leonro@server /]$ sudo rdma dev set mlx5_0 name hfi1_0 > >[leonro@server /]$ sudo rdma dev > >1: hfi1_0: node_type ca fw 3.8.9999 node_guid 5254:00c0:fe12:3455 > >sys_image_guid 5254:00c0:fe12:3455 > > > >Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > >--- > >Changelog: > >v2->v3: > > * Dropped "to be named" words from example section of man > >--- > > man/man8/rdma-dev.8 | 15 ++++++++++++++- > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > >diff --git a/man/man8/rdma-dev.8 b/man/man8/rdma-dev.8 > >index 461681b6..7c275180 100644 > >--- a/man/man8/rdma-dev.8 > >+++ b/man/man8/rdma-dev.8 > >@@ -1,6 +1,6 @@ > > .TH RDMA\-DEV 8 "06 Jul 2017" "iproute2" "Linux" > > .SH NAME > >-rdmak-dev \- RDMA device configuration > >+rdma-dev \- RDMA device configuration > > .SH SYNOPSIS > > .sp > > .ad l > >@@ -22,10 +22,18 @@ rdmak-dev \- RDMA device configuration > > .B rdma dev show > > .RI "[ " DEV " ]" > > > >+.ti -8 > >+.B rdma dev set > >+.RI "[ " DEV " ]" > >+.BR name > >+.BR NEWNAME > >+ > > .ti -8 > > .B rdma dev help > > > > .SH "DESCRIPTION" > >+.SS rdma dev set - rename rdma device > >+ > > .SS rdma dev show - display rdma device attributes > > > > .PP > >@@ -45,6 +53,11 @@ rdma dev show mlx5_3 > > Shows the state of specified RDMA device. > > .RE > > .PP > >+rdma dev set mlx5_3 name rdma_0 > >+.RS 4 > >+Renames the mlx5_3 device to rdma_0. > >+.RE > >+.PP > > > > .SH SEE ALSO > > .BR rdma (8), > >-- > >2.19.1 >
Attachment:
signature.asc
Description: PGP signature
