> From: Leon Romanovsky [mailto:leon@xxxxxxxxxx] > Sent: Tuesday, November 13, 2018 11:25 AM > To: Salil Mehta <salil.mehta@xxxxxxxxxx> > Cc: davem@xxxxxxxxxxxxx; Zhuangyuzeng (Yisen) <yisen.zhuang@xxxxxxxxxx>; > lipeng (Y) <lipeng321@xxxxxxxxxx>; mehta.salil@xxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > rdma@xxxxxxxxxxxxxxx; Linuxarm <linuxarm@xxxxxxxxxx> > Subject: Re: [PATCH net-next 1/5] net: hns3: Enable HW GRO for Rev > B(=0x21) HNS3 hardware > > On Tue, Nov 13, 2018 at 10:13:03AM +0000, Salil Mehta wrote: > > From: Peng Li <lipeng321@xxxxxxxxxx> > > > > HNS3 hardware Revision B(=0x21) supports Hardware GRO feature. This > > patch enables this feature in the HNS3 PF/VF driver. > > > > Signed-off-by: Peng Li <lipeng321@xxxxxxxxxx> > > Signed-off-by: Salil Mehta <salil.mehta@xxxxxxxxxx> > > > > + ret = hclge_config_gro(hdev, true); > > + if (ret) { > > + dev_err(&pdev->dev, > > + "Failed to enable GRO in hardware, ret =%d\n", ret); > > You already printed an error in the hclge_config_gro(). sure. thanks. > > > + goto err_mdiobus_unreg; > > + } > > + > > ret = hclge_init_vlan_config(hdev); > > if (ret) { > > dev_err(&pdev->dev, "VLAN init fail, ret =%d\n", ret); > > @@ -7221,6 +7250,13 @@ static int hclge_reset_ae_dev(struct hnae3_ae_dev *ae_dev) > > return ret; > > } > > > > + ret = hclge_config_gro(hdev, true); > > + if (ret) { > > + dev_err(&pdev->dev, > > + "Failed to enable GRO in hardware, ret =%d\n", ret); > > Ditto ok. > > static int hclgevf_rss_init_hw(struct hclgevf_dev *hdev) > > { > > struct hclgevf_rss_cfg *rss_cfg = &hdev->rss_cfg; > > @@ -2122,6 +2145,13 @@ static int hclgevf_reset_hdev(struct > hclgevf_dev *hdev) > > return ret; > > } > > > > + ret = hclgevf_config_gro(hdev, true); > > + if (ret) { > > + dev_err(&pdev->dev, > > + "failed to enable VF GRO in hardware, ret =%d\n", > ret); > > + return ret; > > Ditto sure. > > > + } > > + > > ret = hclgevf_init_vlan_config(hdev); > > if (ret) { > > dev_err(&hdev->pdev->dev, > > @@ -2199,6 +2229,13 @@ static int hclgevf_init_hdev(struct hclgevf_dev > *hdev) > > goto err_config; > > } > > > > + ret = hclgevf_config_gro(hdev, true); > > + if (ret) { > > + dev_err(&pdev->dev, > > + "Failed to enable VF GRO in hardware, ret =%d\n", > ret); > > Ditto Fixed in V2. Thanks Leon. Best regards Salil.
