On Thu, Nov 08, 2018 at 08:50:05PM +0200, Leon Romanovsky wrote: > On Thu, Nov 08, 2018 at 06:44:46PM +0100, Michał Mirosław wrote: > > This series removes VLAN_TAG_PRESENT use from network drivers in > > preparation to removing its special meaning. > Can you please give an extra explanation why it is removed? > Such series come out-of-blue, for people who are not following > netdev mailing list closely (drivers/infiniband/*). This is one of the steps to remove VLAN_TAG_PRESENT overlap with CFI/DEI bit of VLAN tag. Currently this overlap causes Linux kernel to always clear CFI/DEI in packets. There is skb_vlan_tag_present() that drivers should use to check if the tag in skb is valid. Best Regards, Michał Mirosław