Re: [PATCH RFC 4/4] RDMA/i40iw: Use umem APIs to retrieve optimal HW address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 19, 2018 at 06:34:09PM -0500, Shiraz Saleem wrote:
> Call the core helpers to retrieve the optimal HW aligned address to use
> for the MR, within a supported i40iw page size.
> 
> Remove code in i40iw to determine when MR is backed by 2M huge pages;
> which involves checking the umem->hugetlb flag and VMA inspection.
> The core helpers will return the 2M aligned address if the
> MR is backed by 2M pages.
> 
> Fixes: f26c7c83395b ("i40iw: Add 2MB page support")
> Reviewed-by: Michael J. Ruhl <michael.j.ruhl@xxxxxxxxx>
> Signed-off-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx>
>  drivers/infiniband/hw/i40iw/i40iw_user.h  |  5 +++
>  drivers/infiniband/hw/i40iw/i40iw_verbs.c | 58 +++++++------------------------
>  2 files changed, 17 insertions(+), 46 deletions(-)

This patch looks really good though

Ideally this series would also convert bnxt_re which is the only other
driver to use huge_tlb, then we can drop huge_tlb completely.

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux