On 10/22/2018 10:08 AM, Honggang LI wrote: > From: Honggang Li <honli@xxxxxxxxxx> How is there include loop ? There are ifdef guards around every include file to prevent it being included more than once. However, I agree that the includes removed are superflous now. > Signed-off-by: Honggang Li <honli@xxxxxxxxxx> > --- > include/opensm/osm_congestion_control.h | 1 - > include/opensm/osm_multicast.h | 1 - > include/opensm/osm_sm.h | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/include/opensm/osm_congestion_control.h b/include/opensm/osm_congestion_control.h > index 78e4a642..c59bf888 100644 > --- a/include/opensm/osm_congestion_control.h > +++ b/include/opensm/osm_congestion_control.h > @@ -51,7 +51,6 @@ > #include <opensm/osm_subnet.h> > #include <opensm/osm_log.h> > #include <opensm/osm_sm.h> > -#include <opensm/osm_opensm.h> > #include <opensm/osm_base.h> > > /****s* OpenSM: Base/OSM_DEFAULT_CC_KEY > diff --git a/include/opensm/osm_multicast.h b/include/opensm/osm_multicast.h > index 5b9f427f..3237c87c 100644 > --- a/include/opensm/osm_multicast.h > +++ b/include/opensm/osm_multicast.h > @@ -54,7 +54,6 @@ > #include <opensm/osm_mcm_port.h> > #include <opensm/osm_subnet.h> > #include <opensm/osm_log.h> > -#include <opensm/osm_sm.h> > > #ifdef __cplusplus > # define BEGIN_C_DECLS extern "C" { > diff --git a/include/opensm/osm_sm.h b/include/opensm/osm_sm.h > index f075abb2..d54cf75a 100644 > --- a/include/opensm/osm_sm.h > +++ b/include/opensm/osm_sm.h > @@ -61,7 +61,6 @@ > #include <opensm/osm_port.h> > #include <opensm/osm_db.h> > #include <opensm/osm_remote_sm.h> > -#include <opensm/osm_multicast.h> > > #ifdef __cplusplus > # define BEGIN_C_DECLS extern "C" { >