From: Parav Pandit <parav@xxxxxxxxxxxx>
Currently many rdma drivers are creating device attribute files using
device_create_file() with device specific attributes.
Device specific attributes should be exposed via well defined netlink
device attributes in future.
Introduce an API rdma_set_device_sysfs_group() for existing drivers
to set a group for sysfs attributes for legacy.
This API is only for exposing legacy attributes which existed for
sometime now.
New drivers should not be using this API and rather follow netlink path.
Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx>
Reviewed-by: Daniel Jurgens <danielj@xxxxxxxxxxxx>
Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
---
include/rdma/ib_verbs.h | 28 ++++++++++++++++++++++++++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 62702b4f7e71..83bee125299f 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -2553,8 +2553,11 @@ struct ib_device {
struct module *owner;
struct device dev;
- /* First group for device attributes, NULL terminated array */
- const struct attribute_group *groups[2];
+ /* First group for device attributes,
+ * Second group for driver provided attributes (optional).
+ * It is NULL terminated array.
+ */
+ const struct attribute_group *groups[3];
struct kobject *ports_kobj;
struct list_head port_list;
@@ -4216,5 +4219,26 @@ int rdma_init_netdev(struct ib_device *device, u8 port_num,
unsigned char name_assign_type,
void (*setup)(struct net_device *),
struct net_device *netdev);
+/**
+ * rdma_set_device_sysfs_group - Set device attributes group to have
+ * driver specific sysfs entries at
+ * for infiniband class.
+ *
+ * @device: device pointer for which attributes to be created
+ * @group: Pointer to group which should be added when device
+ * is registered with sysfs.
+ * rdma_set_device_sysfs_group() allows existing drivers to expose one
+ * group per device to have sysfs attributes.
+ *
+ * NOTE: New drivers should not make use of this API; instead new device
+ * parameter should be exposed via netlink command. This API and mechanism
+ * exist only for existing drivers.
+ */
+static inline void
+rdma_set_device_sysfs_group(struct ib_device *dev,
+ const struct attribute_group *group)
+{
+ dev->groups[1] = group;
+}
#endif /* IB_VERBS_H */
--
2.14.4
