On Tue, Oct 09, 2018 at 09:45:30PM +0300, Kamal Heib wrote:
> +/**
> + * struct ib_device_ops - InfiniBand device operations
> + * This structure defines all the InfiniBand device operations, providers will
> + * need to define the supported operations, otherwise they will be set to null.
> + */
> +struct ib_device_ops {
> + int (*query_device)(struct ib_device *device,
> + struct ib_device_attr *device_attr,
> + struct ib_udata *udata);
This whole thing needs to be clang-formatted
And some of the descriptive comments were not preserved.
> struct ib_device {
> /* Do not access @dma_device directly from ULP nor from HW drivers. */
> struct device *dma_device;
>
> + struct ib_device_ops ops;
I don't think this shuld be done at this patch in the series. It would
be better to have the set_device_ops set the existing function
pointers and save renaming the function pointers to that giant
renaming patch
> +
> +
Extra blank line
> char name[IB_DEVICE_NAME_MAX];
>
> struct list_head event_handler_list;
> @@ -2636,6 +2858,7 @@ void ib_unregister_client(struct ib_client *client);
> void *ib_get_client_data(struct ib_device *device, struct ib_client *client);
> void ib_set_client_data(struct ib_device *device, struct ib_client *client,
> void *data);
> +void ib_set_device_ops(struct ib_device *device, struct ib_device_ops *ops);
ops should be const
Jason
