On 2018-10-05 1:07 a.m., Christoph Hellwig wrote: > On Thu, Oct 04, 2018 at 04:29:19PM -0600, Logan Gunthorpe wrote: >>> This needs to handle non bdev namespaces. >> >> As it's coded now the helper never gets called unless ns->bdev is not >> null. But in general, yes you are right, we should probably return NULL >> if ns->bdev is NULL. > > I'd rather skip that for now. Ok, if I do a v10 I'll add it but I don't have anything else queued up at the moment. >> Sure, I guess that makes sense. I've never tried it with fc hardware but >> I assume there's no reason it wouldn't work. >> >> I'll queue these changes up for a v10. > > And I'd wait until someone has actually tested this case. Agreed. Thanks for the review! Logan
