On 2018/10/4 6:38, Jason Gunthorpe wrote: > On Fri, Sep 28, 2018 at 06:43:59PM +0800, Yixian Liu wrote: >> diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c >> index 8c5160e..788c921 100644 >> +++ b/drivers/infiniband/hw/hns/hns_roce_main.c >> @@ -220,6 +220,9 @@ static int hns_roce_query_device(struct ib_device *ib_dev, >> props->max_pkeys = 1; >> props->local_ca_ack_delay = hr_dev->caps.local_ca_ack_delay; >> >> + if (hr_dev->caps.flags & HNS_ROCE_CAP_FLAG_FRMR) >> + props->device_cap_flags |= IB_DEVICE_MEM_MGT_EXTENSIONS; >> + > > The IB spec has a feature set requirement before this bit can be set, > so I think the flags test should be broader.. > > Does hns now implement all the needed features? If I recall send with > invalidate and other things are included in this feature bit, please > check the spec and confirm. > > Jason > I have confirmed IB spec and our hns that send with invalidate is supported but reserved lkey is not. Thus, I will remove this flag set in next version. Thanks
