Re: [PATCH rdma-next] RDMA: Adding a new device managed gids cap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/2/2018 4:54 AM, Leon Romanovsky wrote:
On Tue, Oct 02, 2018 at 11:39:43AM +0300, Kamal Heib wrote:
On Tue, Oct 02, 2018 at 11:07:38AM +0300, Leon Romanovsky wrote:
On Tue, Oct 02, 2018 at 10:52:12AM +0300, Kamal Heib wrote:
To avoid checking if add_gid() and del_gid() are implemented adding a new
device cap flag that will indicate whether a specific device does
support managing his RoCE GIDs table or not.


Why? What will it give us?

Thanks

I plan to work on something similar to "verbs_context_ops" that was introduced in rdma-core,
so, this change will drop the dependency on checking if the providers implemented the call-backs or not.

I would be happy to see this patch as part of whole feature, because
this specific patch gives nothing to us in this current form.

Thanks


Thanks,
Kamal


Agree with Leon here. Patch has to stand on it's own, or at least come along with something that makes it relevant.

-Denny



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux