On 9/25/2018 6:58 PM, Jason Gunthorpe wrote:
diff --git a/include/rdma/rdma_vt.h b/include/rdma/rdma_vt.h index e32facdd9fd3d0..065c9fbe658995 100644 --- a/include/rdma/rdma_vt.h +++ b/include/rdma/rdma_vt.h @@ -429,7 +429,14 @@ static inline void rvt_set_ibdev_name(struct rvt_dev_info *rdi, const char *fmt, const char *name, const int unit) { - snprintf(rdi->ibdev.name, sizeof(rdi->ibdev.name), fmt, name, unit); + /* + * FIXME: rvt and its users want to touch the ibdev before + * registration and have things like the name work. We don't have the + * infrastructure in the core to support this directly today, hack it + * to work by setting the name manually here. + */ + dev_set_name(&rdi->ibdev.dev, fmt, name, unit); + strlcpy(rdi->ibdev.name, dev_name(&rdi->ibdev.dev), IB_DEVICE_NAME_MAX); }/**
I'm OK with this. The comment seems to hint that we will have core infrastructure to support this at some point, is that something you are working on, or are hoping we would do? If we don't actually plan on it can we just remove the FIXME and s/hack/make?
Regardless, seems to be OK to me. I'll let Mike comment further if he likes, but for now.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>
