On Thu, Sep 20, 2018 at 09:56:09PM +0530, Selvin Xavier wrote: > On Thu, Sep 20, 2018 at 9:28 PM Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote: > > > > On Thu, Sep 20, 2018 at 08:02:31AM -0700, Selvin Xavier wrote: > > > Few bug fixes for bnxt_re > > > > > > Patch 1 and 2 are fixes for two smatch warnings. > > > Patch 3 fix some of the resource leaks in error path. > > > Patch 4 changes the rtnl locking during registration to avoid system crash > > > > > > Please review and apply > > > > These patches all need better commit messages for the rc4 timeframe, > > especially since some of them are so long. > > > > rc patches need to be fixing real bug, include a oops report or > > clearly explain how the bug can be triggered. Read the > > > > Documentation/process/stable-kernel-rules.rst > > > > File for guidlines. > > > Patch 4 is a fix for oops. I feel this is needed for RC, even though > its bit longer. Include the oops message, it is much easier to justify that way. Jason
