On Tue, Sep 18, 2018 at 10:56:55AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > There is no need to do custom logic to allocate indexes while kernel > provides specific API for that. I think if we are going to do this then the RDMA_MAX_PORTS should be increased to match the memory overhead of the IDA, at least. Otherwise we are paying a greater allocation cost and getting nothing for it. IIRC an IDA allocates bitmaps in 64*64 bits chunks, so RDMA_MAX_PORTS should be >> 4096 ? Maybe it should be 1<<MINORBITS like NVME does? Reserving more minor numbers is basically free other than the tracking bitmap, which is why Huy was so stingy when this was introduced.. Jason
