On Wed, Sep 05, 2018 at 09:47:56AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > Changelog v0->v1: > * Dropped uverbs_destroy_api in first patch. > * Rebased rest of the patches as an outcome of change in first patch > > > Reuse the char device code interfaces to simplify ib_uverbs_device > creation and destruction. As part of this series, we are sending fix > to cleanup path, which was discovered during internal review, > > The fix definitely can go to -rc, but it means that this series > will be dependent on rdma-rc. > > Thanks > > Parav Pandit (4): > RDMA/uverbs: Fix error cleanup path of ib_uverbs_add_one() > RDMA/core: Depend on device_add() to add device attributes > RDMA/uverbs: Use cdev_device_add() instead of cdev_add() > RDMA/uverbs: Use device.groups to initialize device attributes > > drivers/infiniband/core/sysfs.c | 61 ++++++++++----------- > drivers/infiniband/core/uverbs.h | 5 +- > drivers/infiniband/core/uverbs_main.c | 99 +++++++++++++++++------------------ > include/rdma/ib_verbs.h | 3 ++ > 4 files changed, 80 insertions(+), 88 deletions(-) I really like this series, applied to for-next with the one patch in for-rc.. Thanks, Jason