On Mon, Sep 03, 2018 at 12:49:42PM +0300, Yuval Shaia wrote: > On Fri, Aug 31, 2018 at 06:38:46AM +0800, Honggang LI wrote: > > From: Honggang Li <honli@xxxxxxxxxx> > > > > As all flags are unsigned integer in different size, sanity check the > > value before covert the value to unsigned integer with 'strtoul'. > > Isn't strtoul should do his job? > From man: > "If endptr is not NULL, strtoul() stores the address of the first invalid > character in *endptr". > Agreed. Please drop this patch and review new patch: "parse_group_flag log suspicious group flag value" thanks