On Thu, Aug 30, 2018 at 08:43:30AM +0300, Leon Romanovsky wrote: > On Wed, Aug 29, 2018 at 12:01:14AM +0300, Arseny Maslennikov wrote: > > Pre-3.15 userspace had trouble distinguishing different ports > > of a NIC on a single PCI bus/device/function. To solve this, > > a sysfs field `dev_port' was introduced quite a while ago > > (commit v3.14-rc3-739-g3f85944fe207), and some relevant device > > drivers were fixed to use it, but not in case of IPoIB. > > > > The convention for some reason never got documented in the kernel, but > > was immediately adopted by userspace (notably udev[1][2], biosdevname[3]) > > > > 3/3 documents the sysfs field — that's why I'm CC-ing netdev. > > > > This series was tested on and applies to 4.19-rc1. > > > > [1] https://lists.freedesktop.org/archives/systemd-devel/2014-June/020788.html > > [2] https://lists.freedesktop.org/archives/systemd-devel/2014-July/020804.html > > [3] https://github.com/CloudAutomationNTools/biosdevname/blob/c795d51dd93a5309652f0d635f12a3ecfabfaa72/src/eths.c#L38 > > > > Arseny Maslennikov (3): > > IB/ipoib: Use dev_port to expose network interface port numbers > > IB/ipoib: Stop using dev_id to expose port numbers > > I completely agree with previous Yuval's comment, it makes no sense to > start separate commits for every line. > > Please decide what is best and right behavior and do it, instead of > pushing it up to be the maintainer's problem. > No problem; will squash those two in v2, then. > Thanks > > > Documentation/ABI: document /sys/class/net/*/dev_port > > > > Documentation/ABI/testing/sysfs-class-net | 10 ++++++++++ > > drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +- > > 2 files changed, 11 insertions(+), 1 deletion(-) > > > > -- > > 2.18.0 > >
Attachment:
signature.asc
Description: PGP signature
