Re: [PATCH rdma-next 4/6] RDMA/core: Rate limit MAD error messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 28, 2018 at 01:46:36PM -0400, Dennis Dalessandro wrote:
> On 8/28/2018 7:45 AM, Leon Romanovsky wrote:
> > -	/* Verify the QP requested is supported.  For example, Ethernet devices
> > -	 * will not have QP0 */
> > +	/* Verify the QP requested is supported. For example, Ethernet devices
> > +	 * will not have QP0.
> > +	 */
>
> Just a nit, but maybe either drop the "Verify" down a line or bump this */
> up. Looks odd.

It is "netdev" notation.
Documentation/process/coding-style.rst
 553 For files in net/ and drivers/net/ the preferred style for long (multi-line)
 554 comments is a little different.

Thanks

>
> Regardless patch seems like goodness to me...
>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>
>
>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux